Add Frame::{set_,}{up,down}scale_filter()
#1329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
force-pushed
the
frame-scale-filter
branch
from
e15cc13
to
0c06b78
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 21.32% 21.31% -0.01%
==========================================
Files 156 156
Lines 25121 25129 +8
==========================================
Hits 5356 5356
- Misses 19765 19773 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I wonder if this blurs the lines in terms of expectations of what state is local to a Maybe this should be reset on dropping the Frame? |
Allows changing the filter on the fly, especially useful within RenderElements::draw() where the renderer is inaccessible.
YaLTeR
force-pushed
the
frame-scale-filter
branch
from
0c06b78
to
9e75f1b
Compare
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows changing the filter on the fly, especially useful within
RenderElements::draw()where the renderer is inaccessible.Example use: YaLTeR/niri#189